Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit)!: InputRange remove all deprecated API #2215

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

Does this PR introduce a breaking change?

  • Yes
  • No

@nsbarsukov nsbarsukov self-assigned this Jul 27, 2022
@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 27, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

Visit the preview URL for this PR (updated for commit 9d2d311):

https://taiga-ui--pr2215-input-range-rm-depre-yjugfjmk.web.app

(expires Thu, 28 Jul 2022 13:14:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@nsbarsukov nsbarsukov force-pushed the input-range-rm-deprecated-api branch from 371919f to 9d2d311 Compare July 27, 2022 13:09
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #2215 (9d2d311) into v3.x (b3f416b) will decrease coverage by 0.05%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             v3.x    #2215      +/-   ##
==========================================
- Coverage   60.10%   60.04%   -0.06%     
==========================================
  Files         901      900       -1     
  Lines        9097     9066      -31     
  Branches     1861     1852       -9     
==========================================
- Hits         5468     5444      -24     
+ Misses       3199     3197       -2     
+ Partials      430      425       -5     
Flag Coverage Δ
addon-charts 74.02% <ø> (ø)
addon-doc 20.47% <ø> (ø)
addon-editor 53.92% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 65.37% <ø> (ø)
core 66.50% <ø> (ø)
kit 57.68% <80.00%> (-0.16%) ⬇️
summary 60.04% <80.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/kit/components/input-range/input-range.module.ts 100.00% <ø> (ø)
projects/kit/components/range/range.component.ts 84.48% <ø> (-0.27%) ⬇️
projects/kit/components/range/range.module.ts 100.00% <ø> (ø)
...it/components/input-range/input-range.component.ts 75.00% <80.00%> (-0.95%) ⬇️
projects/kit/abstract/slider/slider.ts 25.00% <0.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f416b...9d2d311. Read the comment docs.

@nsbarsukov nsbarsukov changed the title [WIP] feat(kit)!: InputRange remove all deprecated API feat(kit)!: InputRange remove all deprecated API Jul 27, 2022
@nsbarsukov nsbarsukov marked this pull request as ready for review July 27, 2022 13:41
@nsbarsukov nsbarsukov merged commit 4adf1e0 into v3.x Jul 27, 2022
@nsbarsukov nsbarsukov deleted the input-range-rm-deprecated-api branch July 27, 2022 14:28
@well-done-bot
Copy link

well-done-bot bot commented Jul 27, 2022

'Well done'

This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants