Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kit)!: remove deprecated TUI_MOBILE_AWARE #2099

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 11, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022

Visit the preview URL for this PR (updated for commit 227c48e):

https://taiga-ui--pr2099-remove-deprecated-m4ayfnz0.web.app

(expires Wed, 13 Jul 2022 08:20:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #2099 (227c48e) into v3.x (9be4ddc) will decrease coverage by 0.01%.
The diff coverage is 43.37%.

@@            Coverage Diff             @@
##             v3.x    #2099      +/-   ##
==========================================
- Coverage   61.34%   61.32%   -0.02%     
==========================================
  Files         933      932       -1     
  Lines        9806     9790      -16     
  Branches     1927     1921       -6     
==========================================
- Hits         6015     6004      -11     
  Misses       3341     3341              
+ Partials      450      445       -5     
Flag Coverage Δ
addon-charts 74.76% <100.00%> (ø)
addon-doc 21.11% <ø> (ø)
addon-editor 46.11% <0.00%> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 79.59% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 65.85% <25.00%> (-0.17%) ⬇️
core 67.27% <30.76%> (ø)
kit 60.88% <55.81%> (+0.04%) ⬆️
summary 61.32% <43.37%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/addon-doc/src/components/demo/demo.component.ts 3.57% <ø> (ø)
...or/directives/design-mode/design-mode.directive.ts 22.30% <0.00%> (ø)
.../cdk/directives/auto-focus/handlers/ios.handler.ts 2.12% <0.00%> (ø)
.../cdk/directives/focus-trap/focus-trap.directive.ts 5.88% <0.00%> (ø)
...ojects/cdk/observables/focus-visible-observable.ts 8.33% <0.00%> (ø)
projects/cdk/utils/focus/get-native-focused.ts 66.66% <ø> (-4.77%) ⬇️
projects/cdk/utils/focus/is-native-focused.ts 0.00% <0.00%> (-100.00%) ⬇️
projects/cdk/utils/focus/move-focus.ts 66.66% <0.00%> (-4.77%) ⬇️
projects/cdk/utils/format/px.ts 100.00% <ø> (ø)
...s/core/components/data-list/data-list.component.ts 65.38% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be4ddc...227c48e. Read the comment docs.

@tinkoff-bot tinkoff-bot force-pushed the v3.x branch 2 times, most recently from 09505ac to 5cd3e2d Compare July 11, 2022 15:09
@tinkoff-bot tinkoff-bot force-pushed the remove-deprecated branch 2 times, most recently from 71fc701 to a41b973 Compare July 11, 2022 15:12
@splincode splincode force-pushed the remove-deprecated branch from a41b973 to c6c382e Compare July 12, 2022 07:56
@vladimirpotekhin vladimirpotekhin merged commit 8ba8b8f into v3.x Jul 12, 2022
@vladimirpotekhin vladimirpotekhin deleted the remove-deprecated branch July 12, 2022 08:54
@well-done-bot
Copy link

well-done-bot bot commented Jul 12, 2022

'Well done'

This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants