Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(addon-commerce, addon-chart)!: remove deprecated enums #2095

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 11, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022

Visit the preview URL for this PR (updated for commit 01e2564):

https://taiga-ui--pr2095-addon-commerce-enums-wemqyttj.web.app

(expires Wed, 13 Jul 2022 14:36:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #2095 (01e2564) into v3.x (2e43f07) will decrease coverage by 0.08%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             v3.x    #2095      +/-   ##
==========================================
- Coverage   61.37%   61.28%   -0.09%     
==========================================
  Files         933      931       -2     
  Lines        9783     9762      -21     
  Branches     1916     1916              
==========================================
- Hits         6004     5983      -21     
  Misses       3334     3334              
  Partials      445      445              
Flag Coverage Δ
addon-charts 73.96% <96.15%> (-0.81%) ⬇️
addon-doc 21.11% <ø> (ø)
addon-editor 46.11% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 79.59% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 66.09% <100.00%> (-0.03%) ⬇️
core 67.31% <80.00%> (ø)
kit 60.86% <62.50%> (ø)
summary 61.28% <87.50%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/addon-commerce/components/money/money-options.ts 100.00% <ø> (ø)
...ommerce/components/money/pipes/sign-symbol.pipe.ts 100.00% <ø> (ø)
...merce/components/money/utils/format-sign-symbol.ts 100.00% <ø> (ø)
...ojects/addon-commerce/utils/get-currency-symbol.ts 27.27% <ø> (-3.17%) ⬇️
...jects/addon-commerce/utils/is-card-number-valid.ts 100.00% <ø> (ø)
...addon-commerce/validators/card-number.validator.ts 50.00% <0.00%> (ø)
projects/cdk/utils/focus/is-native-focused-in.ts 100.00% <ø> (ø)
.../kit/components/radio-list/radio-list.component.ts 31.81% <0.00%> (ø)
...ectives/dropdown-hover/dropdown-hover.directive.ts 5.26% <0.00%> (ø)
...imitive-textfield/primitive-textfield.component.ts 78.66% <50.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e43f07...01e2564. Read the comment docs.

Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty file ?

projects/kit/components/input-file/input-file.component.ts

projects/cdk/utils/focus/index.ts Outdated Show resolved Hide resolved
@tinkoff-bot tinkoff-bot force-pushed the addon-commerce-enums branch 2 times, most recently from 36a920a to 0f85cac Compare July 11, 2022 15:12
@vladimirpotekhin vladimirpotekhin force-pushed the addon-commerce-enums branch 3 times, most recently from f317b60 to 3c62ca3 Compare July 11, 2022 15:41
This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants