Skip to content

Classification notebook #997

Merged
merged 11 commits into from
Nov 23, 2022
Merged

Classification notebook #997

merged 11 commits into from
Nov 23, 2022

Conversation

alex-hse-repository
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

@alex-hse-repository alex-hse-repository self-assigned this Oct 26, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alex-hse-repository alex-hse-repository marked this pull request as draft October 26, 2022 10:02
@github-actions
Copy link

github-actions bot commented Oct 26, 2022

🚀 Deployed on https://deploy-preview-997--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 26, 2022 10:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 31, 2022 07:42 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #997 (b6ab64f) into master (5d9103f) will decrease coverage by 0.07%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
- Coverage   85.82%   85.74%   -0.08%     
==========================================
  Files         162      162              
  Lines        8605     8614       +9     
==========================================
+ Hits         7385     7386       +1     
- Misses       1220     1228       +8     
Impacted Files Coverage Δ
etna/experimental/classification/predictability.py 81.25% <45.45%> (-18.75%) ⬇️
etna/auto/runner/utils.py 50.00% <0.00%> (-50.00%) ⬇️
etna/models/nn/deepar.py 98.93% <0.00%> (-0.02%) ⬇️
etna/models/nn/tft.py 99.10% <0.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request October 31, 2022 08:13 Inactive
@alex-hse-repository alex-hse-repository marked this pull request as ready for review November 22, 2022 07:55
@github-actions github-actions bot temporarily deployed to pull request November 22, 2022 08:00 Inactive
dataset_freq:
Frequency of the dataset.
path:
Path to save the file with model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Raises block please

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@julia-shenshina
Copy link
Contributor

add Classification notebook to tutorials section in docs and CHANGELOG please

@review-notebook-app
Copy link

review-notebook-app bot commented Nov 22, 2022

View / edit / reply to this conversation on ReviewNB

julia-shenshina commented on 2022-11-22T15:39:15Z
----------------------------------------------------------------

why do we need this plot? as I can see, it is not connected with false-positive statement because there are no intersections over segments 🤔


alex-hse-repository commented on 2022-11-22T16:37:53Z
----------------------------------------------------------------

What do you mean? These are the segments with the good metrics which were predicted to be bad(so false positives). Table above(metrics.tail(10)) shows metrics for these segments

Copy link
Collaborator Author

What do you mean? These are the segments with the good metrics which were predicted to be bad(so false positives). Table above(metrics.tail(10)) shows metrics for these segments


View entire conversation on ReviewNB

@github-actions github-actions bot temporarily deployed to pull request November 22, 2022 16:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 23, 2022 08:28 Inactive
@alex-hse-repository alex-hse-repository merged commit a465a2a into master Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants