Skip to content

ADD: greater_is_better property #921

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Sep 6, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

🚀 Deployed on https://deploy-preview-921--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 6, 2022 15:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 6, 2022 15:10 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #921 (4a36eb6) into master (7bff536) will decrease coverage by 0.26%.
The diff coverage is 71.73%.

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   85.04%   84.77%   -0.27%     
==========================================
  Files         133      133              
  Lines        7548     7593      +45     
==========================================
+ Hits         6419     6437      +18     
- Misses       1129     1156      +27     
Impacted Files Coverage Δ
etna/metrics/intervals_metrics.py 94.44% <66.66%> (-3.48%) ⬇️
etna/metrics/metrics.py 86.44% <66.66%> (-13.56%) ⬇️
etna/metrics/base.py 93.67% <81.25%> (-3.21%) ⬇️
etna/libs/tsfresh/significance_tests.py 31.88% <0.00%> (-14.50%) ⬇️
etna/transforms/nn/pytorch_forecasting.py 90.47% <0.00%> (-4.77%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Mr-Geekman
Mr-Geekman previously approved these changes Sep 6, 2022
@martins0n martins0n self-assigned this Sep 6, 2022
@martins0n martins0n merged commit 18a064a into master Sep 7, 2022
@martins0n martins0n deleted the metrics/greater-property branch September 7, 2022 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants