Skip to content

Fix cap/floor bug in ProphetModel #842

Merged
merged 6 commits into from
Aug 11, 2022
Merged

Fix cap/floor bug in ProphetModel #842

merged 6 commits into from
Aug 11, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Aug 9, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #841.

Closing issues

Closes #841.

@Mr-Geekman Mr-Geekman self-assigned this Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

🚀 Deployed on https://deploy-preview-842--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 9, 2022 13:57 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #842 (e1525e2) into master (1565b18) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   49.34%   49.34%           
=======================================
  Files         130      130           
  Lines        7409     7411    +2     
=======================================
+ Hits         3656     3657    +1     
- Misses       3753     3754    +1     
Impacted Files Coverage Δ
etna/models/prophet.py 90.69% <33.33%> (-0.97%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request August 11, 2022 07:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 11, 2022 07:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 11, 2022 07:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 11, 2022 08:02 Inactive
@Mr-Geekman Mr-Geekman merged commit 910441d into master Aug 11, 2022
@Mr-Geekman Mr-Geekman deleted the issue-841 branch August 11, 2022 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ProphetModel doesn't work with cap and floor regressors
3 participants