Skip to content

Rename catboost #779

Merged
merged 11 commits into from
Jul 5, 2022
Merged

Rename catboost #779

merged 11 commits into from
Jul 5, 2022

Conversation

julia-shenshina
Copy link
Contributor

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #737

@julia-shenshina julia-shenshina marked this pull request as draft July 4, 2022 09:26
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

🚀 Deployed on https://deploy-preview-779--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 4, 2022 09:34 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #779 (8266d43) into master (01b349d) will decrease coverage by 34.16%.
The diff coverage is 42.85%.

@@             Coverage Diff             @@
##           master     #779       +/-   ##
===========================================
- Coverage   83.74%   49.57%   -34.17%     
===========================================
  Files         123      123               
  Lines        6870     6895       +25     
===========================================
- Hits         5753     3418     -2335     
- Misses       1117     3477     +2360     
Impacted Files Coverage Δ
etna/models/catboost.py 64.28% <38.46%> (-35.72%) ⬇️
etna/models/__init__.py 100.00% <100.00%> (ø)
etna/commands/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
etna/commands/backtest_command.py 0.00% <0.00%> (-97.06%) ⬇️
etna/commands/forecast_command.py 0.00% <0.00%> (-94.88%) ⬇️
etna/commands/__main__.py 0.00% <0.00%> (-87.50%) ⬇️
etna/commands/resolvers.py 0.00% <0.00%> (-80.00%) ⬇️
etna/analysis/outliers/density_outliers.py 22.44% <0.00%> (-75.52%) ⬇️
etna/datasets/datasets_generation.py 27.02% <0.00%> (-72.98%) ⬇️
etna/transforms/timestamp/time_flags.py 27.02% <0.00%> (-72.98%) ⬇️
... and 74 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions github-actions bot temporarily deployed to pull request July 4, 2022 09:52 Inactive
etna/models/catboost.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 4, 2022 09:55 Inactive
etna/models/catboost.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 4, 2022 10:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2022 09:47 Inactive
@julia-shenshina julia-shenshina marked this pull request as ready for review July 5, 2022 09:51
@github-actions github-actions bot temporarily deployed to pull request July 5, 2022 09:51 Inactive
@julia-shenshina julia-shenshina changed the title [WIP] Rename catboost Rename catboost Jul 5, 2022
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add record to CHANGELOG.md

@github-actions github-actions bot temporarily deployed to pull request July 5, 2022 10:37 Inactive
@martins0n martins0n enabled auto-merge (squash) July 5, 2022 10:40
@martins0n martins0n merged commit 2a1481c into master Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Catboost models
4 participants