From 84fcf7fb28f172924fee6e28594f0018103c570b Mon Sep 17 00:00:00 2001 From: martins0n Date: Fri, 8 Apr 2022 23:53:32 +0300 Subject: [PATCH 1/3] FIX: passing non default params for default models --- etna/transforms/decomposition/stl.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/etna/transforms/decomposition/stl.py b/etna/transforms/decomposition/stl.py index 2ec400cd5..53ef4707b 100644 --- a/etna/transforms/decomposition/stl.py +++ b/etna/transforms/decomposition/stl.py @@ -58,10 +58,12 @@ def __init__( if isinstance(model, str): if model == "arima": self.model = ARIMA - model_kwargs = {"order": (1, 1, 0)} + if len(model_kwargs) == 0: + model_kwargs = {"order": (1, 1, 0)} elif model == "holt": self.model = ETSModel - model_kwargs = {"trend": "add"} + if len(model_kwargs) == 0: + model_kwargs = {"trend": "add"} else: raise ValueError(f"Not a valid option for model: {model}") elif isinstance(model, TimeSeriesModel): From 6d98b59c17b043bd4ade449a346300038573baee Mon Sep 17 00:00:00 2001 From: martins0n Date: Fri, 8 Apr 2022 23:56:16 +0300 Subject: [PATCH 2/3] FIX: changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f5b6db3a..3fba14cf3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,7 +29,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - ### Fixed -- +- FIX: passing non default params for default models STLTransform ([#641](https://github.com/tinkoff-ai/etna/pull/641)) - - Fixed bug in models `get_model` method ([#623](https://github.com/tinkoff-ai/etna/pull/623)) - Fixed unsafe comparison in plots ([#611](https://github.com/tinkoff-ai/etna/pull/611)) From 349a8bca0f51374116d6a15838d7414607fdaac1 Mon Sep 17 00:00:00 2001 From: martins0n Date: Fri, 8 Apr 2022 23:58:11 +0300 Subject: [PATCH 3/3] FIX: changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3fba14cf3..e79c2ee95 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,7 +29,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - ### Fixed -- FIX: passing non default params for default models STLTransform ([#641](https://github.com/tinkoff-ai/etna/pull/641)) +- Passing non default params for default models STLTransform ([#641](https://github.com/tinkoff-ai/etna/pull/641)) - - Fixed bug in models `get_model` method ([#623](https://github.com/tinkoff-ai/etna/pull/623)) - Fixed unsafe comparison in plots ([#611](https://github.com/tinkoff-ai/etna/pull/611))