Add option day_number_in_year to DateFlagsTransform
#552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-hse-repository
suggested changes
Feb 21, 2022
| @@ -228,11 +239,25 @@ def _get_day_number_in_month(timestamp_series: pd.Series) -> np.ndarray: | |||
| """Generate an array with the number of the day in the month.""" | |||
| return timestamp_series.apply(lambda x: x.day).values | |||
|
|
|||
| @staticmethod | |||
| def _get_day_number_in_year(timestamp_series: pd.Series) -> np.ndarray: | |||
| """Generate an array with the number of the day in a year, lear year numeration, starts with 1.""" | |||
There was a problem hiding this comment.
Suggested change
| """Generate an array with the number of the day in a year, lear year numeration, starts with 1.""" | |
| """Generate an array with the numbers of the days in a year, leap year numeration, starts with 1.""" |
There was a problem hiding this comment.
Get the right variant from the constructor docstring
| @@ -34,6 +35,8 @@ def __init__( | |||
| if True, add column with weekday info to feature dataframe in transform | |||
| day_number_in_month: | |||
| if True, add column with day info to feature dataframe in transform | |||
| day_number_in_year: | |||
| if True, add column with number of day in a year, leap year numeration, starts with 1 | |||
There was a problem hiding this comment.
May you rewrite it to make it clear
|
May you also remove "regressor_" prefix in out_colum generation logic |
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 87.25% 87.28% +0.02%
==========================================
Files 118 118
Lines 5681 5692 +11
==========================================
+ Hits 4957 4968 +11
Misses 724 724
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Look #546.
Related Issue
#546.
Closing issues
Closes #546.