Skip to content

Add FourierTransform #306

Merged
merged 7 commits into from
Nov 30, 2021
Merged

Add FourierTransform #306

merged 7 commits into from
Nov 30, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Nov 23, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

See #292. But there was some change in constructors and mods indexation.

Related Issue

#292.

Closing issues

Closes #292.

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Nov 23, 2021
@Mr-Geekman Mr-Geekman self-assigned this Nov 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #306 (ee94bb1) into master (38623dc) will increase coverage by 0.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   87.16%   88.00%   +0.83%     
==========================================
  Files          97       98       +1     
  Lines        4762     4811      +49     
==========================================
+ Hits         4151     4234      +83     
+ Misses        611      577      -34     
Impacted Files Coverage Δ
etna/transforms/__init__.py 100.00% <100.00%> (ø)
etna/transforms/fourier.py 100.00% <100.00%> (ø)
etna/loggers/base.py 94.23% <0.00%> (+1.92%) ⬆️
etna/transforms/pytorch_forecasting.py 95.29% <0.00%> (+7.05%) ⬆️
etna/core/mixins.py 94.73% <0.00%> (+15.78%) ⬆️
etna/models/nn/tft.py 100.00% <0.00%> (+22.64%) ⬆️
etna/models/nn/deepar.py 100.00% <0.00%> (+23.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38623dc...ee94bb1. Read the comment docs.

@Mr-Geekman Mr-Geekman marked this pull request as ready for review November 23, 2021 09:14
@martins0n martins0n self-requested a review November 24, 2021 08:00
Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment it looks great!

etna/transforms/fourier.py Show resolved Hide resolved
Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@iKintosh iKintosh merged commit e495f57 into master Nov 30, 2021
@iKintosh iKintosh deleted the issue-292 branch November 30, 2021 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FourierTransform
3 participants