Skip to content

Metric's representation in backtest #192

Merged
merged 21 commits into from
Oct 13, 2021
Merged

Metric's representation in backtest #192

merged 21 commits into from
Oct 13, 2021

Conversation

julia-shenshina
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #192 (28de5b0) into master (9a9f2c3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   87.83%   87.85%   +0.01%     
==========================================
  Files          75       75              
  Lines        3453     3458       +5     
==========================================
+ Hits         3033     3038       +5     
  Misses        420      420              
Impacted Files Coverage Δ
etna/model_selection/backtest.py 97.60% <100.00%> (ø)
etna/pipeline/pipeline.py 99.28% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a9f2c3...28de5b0. Read the comment docs.

Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@julia-shenshina julia-shenshina merged commit fd34ec1 into master Oct 13, 2021
@iKintosh iKintosh deleted the issue121 branch October 15, 2021 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants