Skip to content

N-BEATS Models #1302

Merged
merged 41 commits into from
Jul 11, 2023
Merged

N-BEATS Models #1302

merged 41 commits into from
Jul 11, 2023

Conversation

brsnw250
Copy link
Collaborator

@brsnw250 brsnw250 commented Jun 30, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Performance on M4 dataset

Model M4 Yearly SMAPE M4 Quarterly SMAPE M4 Monthly SMAPE M4 Weekly SMAPE
NBeatsInterpretableModel 13.4007 9.9618 13.055 6.6422
NBeatsGenericModel 13.4042 9.9076 13.4028 6.8783

Closing issues

closes #1022

@brsnw250 brsnw250 self-assigned this Jun 30, 2023
# Conflicts:
#	tests/test_models/test_inference/test_forecast.py
#	tests/test_models/test_inference/test_predict.py
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #1302 (74c603a) into master (0225a51) will decrease coverage by 35.78%.
The diff coverage is 70.74%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #1302       +/-   ##
===========================================
- Coverage   88.37%   52.60%   -35.78%     
===========================================
  Files         197      203        +6     
  Lines       12131    12461      +330     
===========================================
- Hits        10721     6555     -4166     
- Misses       1410     5906     +4496     
Impacted Files Coverage Δ
etna/models/nn/nbeats/utils.py 30.18% <30.18%> (ø)
etna/models/nn/nbeats/blocks.py 69.62% <69.62%> (ø)
etna/models/nn/nbeats/metrics.py 71.05% <71.05%> (ø)
etna/models/nn/nbeats/nets.py 77.50% <77.50%> (ø)
etna/models/nn/nbeats/nbeats.py 89.87% <89.87%> (ø)
etna/models/nn/__init__.py 100.00% <100.00%> (ø)
etna/models/nn/nbeats/__init__.py 100.00% <100.00%> (ø)

... and 125 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

@github-actions github-actions bot temporarily deployed to pull request June 30, 2023 11:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 30, 2023 15:18 Inactive
@brsnw250 brsnw250 changed the title Issue 1022 N-BETS Models Jun 30, 2023
@github-actions github-actions bot temporarily deployed to pull request July 4, 2023 08:27 Inactive
@martins0n martins0n requested a review from Mr-Geekman July 5, 2023 07:38
etna/models/nn/nbeats/blocks.py Outdated Show resolved Hide resolved
etna/models/nn/nbeats/blocks.py Show resolved Hide resolved
etna/models/nn/nbeats/blocks.py Show resolved Hide resolved
etna/models/nn/nbeats/blocks.py Show resolved Hide resolved
etna/models/nn/nbeats/blocks.py Show resolved Hide resolved
tests/test_models/nn/nbeats/test_blocks.py Show resolved Hide resolved
etna/models/nn/nbeats/nbeats.py Show resolved Hide resolved
tests/test_models/nn/nbeats/test_nbeats_utils.py Outdated Show resolved Hide resolved
etna/models/nn/nbeats/utils.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 7, 2023 10:11 Inactive
@brsnw250 brsnw250 requested a review from Mr-Geekman July 7, 2023 12:20
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 11:36 Inactive
Copy link
Contributor

@Mr-Geekman Mr-Geekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little question.

etna/models/nn/nbeats/utils.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 14:38 Inactive
Mr-Geekman
Mr-Geekman previously approved these changes Jul 10, 2023
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 15:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 17:30 Inactive
@martins0n martins0n self-requested a review July 11, 2023 08:03
@brsnw250 brsnw250 merged commit 752e35b into master Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NBeats net for etna
4 participants