-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
🚀 Deployed on https://deploy-preview-1272--etna-docs.netlify.app |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## automl-2.0 #1272 +/- ##
=============================================
Coverage ? 88.41%
=============================================
Files ? 186
Lines ? 11241
Branches ? 0
=============================================
Hits ? 9939
Misses ? 1302
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
etna/auto/auto.py
Outdated
self._pool_optuna: Optional[Optuna] = None | ||
|
||
root_folder = self.experiment_folder if self.experiment_folder is not None else "" | ||
self._pool_folder = f"{root_folder}/pool" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If root_folder
is None we'll get somenthing like /pool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was my intention. Is it bad? What name should we use in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in case of saving artifacts like files - we would save it to /pool
folder and it's a potential risky situation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you suggest using pool
instead of /pool
if there is not self.experiment_folder
? I'm ok with this.
…rials for Auto and Tune
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Before submitting (must do checklist)
Proposed Changes
Look at #1269.
Closing issues
Closes #1269.