You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently SeasonalMovingAverageModel and MovingAverageModel don't pass some tests written in test_inference. Try also to make sure that in-sample predictions work as expected.
Expected behavior
Tests are passed.
How To Reproduce
Run tests in test_inference.
Environment
No response
Additional context
No response
Checklist
Bug appears at the latest library version
The text was updated successfully, but these errors were encountered:
Mr-Geekman
changed the title
[BUG] Teach SeasonalMovingAverageModel and MovingAverageModel to work with out-sample predictions
[BUG] Teach SeasonalMovingAverageModel to work with out-sample predictions
Jul 14, 2022
I've run the tests in tests/test_models/test_inference and after thorough examination have found that both MovingAverageWindow and SeasonalMovingAverageWindow pass all the tests.
However, upon examining these models more closely, I found two behaviours I believe to be bugs.
I link Colab notebook with their reproduction and description.
It seems that we already completed this particular task, I'm sorry we forgot to close it.
About colab notebook. It seems like you are confusing classes. There are two separate classes: SeasonalMovingAverageModel and _SeasonalMovingAverageModel. The first is etna model that works with TSDataset, the second is private class that holds implementation details and works with pd.DataFrame.
🐛 Bug Report
Currently
SeasonalMovingAverageModel
andMovingAverageModel
don't pass some tests written intest_inference
. Try also to make sure that in-sample predictions work as expected.Expected behavior
Tests are passed.
How To Reproduce
Run tests in
test_inference
.Environment
No response
Additional context
No response
Checklist
The text was updated successfully, but these errors were encountered: