Skip to content

[BUG] Teach SeasonalMovingAverageModel to work with out-sample predictions #789

Closed
1 task done
Mr-Geekman opened this issue Jul 8, 2022 · 3 comments
Closed
1 task done
Labels
bug Something isn't working
Milestone

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Jul 8, 2022

🐛 Bug Report

Currently SeasonalMovingAverageModel and MovingAverageModel don't pass some tests written in test_inference. Try also to make sure that in-sample predictions work as expected.

Expected behavior

Tests are passed.

How To Reproduce

Run tests in test_inference.

Environment

No response

Additional context

No response

Checklist

  • Bug appears at the latest library version
@Mr-Geekman Mr-Geekman added the bug Something isn't working label Jul 8, 2022
@Mr-Geekman Mr-Geekman moved this to Specification in etna board Jul 8, 2022
@Mr-Geekman Mr-Geekman added this to the Inference milestone Jul 8, 2022
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Jul 12, 2022
@Mr-Geekman Mr-Geekman changed the title [BUG] Teach SeasonalMovingAverageModel and MovingAverageModel to work with out-sample predictions [BUG] Teach SeasonalMovingAverageModel to work with out-sample predictions Jul 14, 2022
@alex-hse-repository alex-hse-repository moved this from Todo to Specification in etna board Jul 15, 2022
@GooseIt
Copy link
Contributor

GooseIt commented Feb 9, 2023

I've run the tests in tests/test_models/test_inference and after thorough examination have found that both MovingAverageWindow and SeasonalMovingAverageWindow pass all the tests.
However, upon examining these models more closely, I found two behaviours I believe to be bugs.
I link Colab notebook with their reproduction and description.

@Mr-Geekman
Copy link
Contributor Author

It seems that we already completed this particular task, I'm sorry we forgot to close it.

About colab notebook. It seems like you are confusing classes. There are two separate classes: SeasonalMovingAverageModel and _SeasonalMovingAverageModel. The first is etna model that works with TSDataset, the second is private class that holds implementation details and works with pd.DataFrame.

@Mr-Geekman
Copy link
Contributor Author

It seems like this task is already done during Inference track.

@github-project-automation github-project-automation bot moved this from Specification to Done in etna board Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants