Skip to content

[BUG] Raise errors in models.nn if they can't make in-sample and some cases out-sample predictions #787

Closed
1 task done
Mr-Geekman opened this issue Jul 8, 2022 · 0 comments · Fixed by #813
Closed
1 task done

[BUG] Raise errors in models.nn if they can't make in-sample and some cases out-sample predictions #787

Mr-Geekman opened this issue Jul 8, 2022 · 0 comments · Fixed by #813
Assignees
@martins0n
Labels
bug Something isn't working
Milestone
Inference

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Jul 8, 2022 •
edited
Loading

🐛 Bug Report

Currently models.nn don't pass some tests written in test_inference. We want to fix this.

  1. DeepARModel fail some tests because of non-deterministic behaviour -- not necessary to fix.
  2. TFTModel fail tests because of errors in forecast (and these errors present in DeepARModel too).

In-sample:

  1. Remember last train date.
  2. If we have in forecast date within train then raise an error that we can't make in-sample predictions with this model.

Out-sample:

  1. Remember last train date.
  2. If we see some gap between last train date and first forecast date then raise an error that we can't make out-sample forecasts with gap with this model.

Expected behavior

Tests are passed. Correct errors are thrown.

How To Reproduce

Run tests written in test_inference.

Environment

No response

Additional context

No response

Checklist

  • Bug appears at the latest library version
@Mr-Geekman Mr-Geekman added the bug Something isn't working label Jul 8, 2022
@Mr-Geekman Mr-Geekman added this to the Inference milestone Jul 8, 2022
@Mr-Geekman Mr-Geekman moved this to Specification in etna board Jul 8, 2022
@Mr-Geekman Mr-Geekman changed the title [BUG] Teach models.nn to work with in-sample predictions and make out-sample predictions more explicit [BUG] Teach models.nn to work with in-sample predictions and out-sample predictions Jul 12, 2022
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Jul 12, 2022
@Mr-Geekman Mr-Geekman changed the title [BUG] Teach models.nn to work with in-sample predictions and out-sample predictions [BUG] Teach models.nn to work with in-sample predictions and out-sample predictions correclty Jul 14, 2022
@Mr-Geekman Mr-Geekman mentioned this issue Jul 15, 2022
Open
@martins0n martins0n self-assigned this Jul 22, 2022
@martins0n martins0n moved this from Todo to In Progress in etna board Jul 22, 2022
@Mr-Geekman Mr-Geekman changed the title [BUG] Teach models.nn to work with in-sample predictions and out-sample predictions correclty [BUG] Raise errors in models.nn if they can't make in-sample and some cases out-sample predictions Jul 22, 2022
martins0n added a commit that referenced this issue Jul 22, 2022
@martins0n
[BUG] Teach models.nn to work with in-sample predictions and out-sa…
ffed419 
…mple predictions correclty

Fixes #787
@martins0n martins0n mentioned this issue Jul 22, 2022
Merged
4 tasks
Repository owner moved this from In Progress to Done in etna board Jul 22, 2022
@Mr-Geekman Mr-Geekman mentioned this issue Aug 14, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@martins0n martins0n

Labels
bug Something isn't working
Projects
etna board
Status: Done
Milestone
Inference
2 participants
@martins0n @Mr-Geekman