Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching status triggers new reconciliation loop #54

Open
chrisdoherty4 opened this issue Jul 15, 2022 · 0 comments
Open

Patching status triggers new reconciliation loop #54

chrisdoherty4 opened this issue Jul 15, 2022 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Jul 15, 2022

Currently, several of our controllers (originally identified in the Task controller) don't filter status field updates resulting in status patches triggering additional reconciliation requests. This behavior is actually relied upon by a task controller but feels very incidental as opposed to intentional.

We should refactor to filter for status field updates and explicitly issue a requeue if that's the desired behavior. This will create code that's much clearer in its intent.

The GenerationChangedPredicate can be applied to the For(...) method when registering with the controller manager. This ensures we associate the predicate with a single type in the event more types are listened to such as the job controller.

@chrisdoherty4 chrisdoherty4 added this to the 0.2 milestone Jul 15, 2022
@chrisdoherty4 chrisdoherty4 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 15, 2022
@chrisdoherty4 chrisdoherty4 added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/bug Categorizes issue or PR as related to a bug. labels Aug 31, 2022
@chrisdoherty4 chrisdoherty4 added kind/bug Categorizes issue or PR as related to a bug. and removed kind/bug Categorizes issue or PR as related to a bug. labels Sep 8, 2022
@chrisdoherty4 chrisdoherty4 modified the milestones: v0.2, v0.3 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

1 participant