getbinariesfromquay: Remove - separating arch from variant #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This naming scheme seemed weird to me so I went looking around at other Go projects. None of the projects that I found that had multi-arch release binaries used this scheme, instead they just append the variant to arch. Appending the variant to the arch also makes a lot of sense if you think of the naming schme as $binary-$os-$cpu and $cpu=$arch$variant. Keeping arch and variant together as $cpu is also more consistent, and consitency is great :D. Signed-off-by: Manuel Mendez <[email protected]>
mmlb
added
the
breaking-change
gianarb
approved these changes
Jan 20, 2021
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
…l#38) ## Description Renames binaries to be more consistent in and of itself and also compared to other Go projects that provide multi-arch binaries. ## Why is this needed @gianarb asked me to rename the binaries in tinkerbell/smee#122 to match this scheme, but I think that this PR is the better directon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames binaries to be more consistent in and of itself and also compared to other Go projects that provide multi-arch binaries.
Why is this needed
@gianarb asked me to rename the binaries in tinkerbell/smee#122 to match this scheme, but I think that this PR is the better directon.