From e8ffd43a29e49efeda93b7ce93d1cd618eb133a5 Mon Sep 17 00:00:00 2001 From: Manuel Mendez Date: Wed, 20 Jan 2021 09:33:14 -0500 Subject: [PATCH] getbinariesfromquay: Remove - separating arch from variant This naming scheme seemed weird to me so I went looking around at other Go projects. None of the projects that I found that had multi-arch release binaries used this scheme, instead they just append the variant to arch. Appending the variant to the arch also makes a lot of sense if you think of the naming schme as $binary-$os-$cpu and $cpu=$arch$variant. Keeping arch and variant together as $cpu is also more consistent, and consitency is great :D. Signed-off-by: Manuel Mendez --- cmd/getbinariesfromquay/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/getbinariesfromquay/main.go b/cmd/getbinariesfromquay/main.go index 5dad8afb..625d35f2 100644 --- a/cmd/getbinariesfromquay/main.go +++ b/cmd/getbinariesfromquay/main.go @@ -88,7 +88,7 @@ func main() { } if arch.Platform.Variant != "" { syss.VariantChoice = arch.Platform.Variant - imgDir = imgDir + "-" + arch.Platform.Variant + imgDir = imgDir + arch.Platform.Variant } archImg, err := docker.ImageFromName(ctx, syss, imageR) if err != nil {