Skip to content

Commit

Permalink
Rename _vagrant to vagrant
Browse files Browse the repository at this point in the history
Apparently the idea to prefix a package with an underscore is not that
smart as I thought. Yes `go test` does not run it by default when you
run `go test ./...` but also other commands like `go mod tidy` do not
work consistently.

Nothing changes in practice. By default only unit tests run. Setting the
new environment variable: `TEST_WITH_VAGRANT` you include the test who
uses vagrant.

Signed-off-by: Gianluca Arbezzano <[email protected]>
  • Loading branch information
Gianluca Arbezzano committed Mar 18, 2021
1 parent dbf51c8 commit c5dd65c
Show file tree
Hide file tree
Showing 5 changed files with 63 additions and 57 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/vagrant-packet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,15 @@ jobs:
vagrant-setup:
if: contains(github.event.pull_request.labels.*.name, 'ci-check/vagrant-setup')
runs-on: vagrant
env:
TEST_WITH_VAGRANT: "yes"
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Cleanup state directory
run: |
rm -rf ./deploy/state
- name: Vagrant Test
run: |
export VAGRANT_DEFAULT_PROVIDER="virtualbox"
go test --timeout 1h -v ./test/_vagrant
go test --timeout 1h -v ./test/vagrant
6 changes: 3 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ go 1.15

require (
github.com/containers/image v3.0.2+incompatible
github.com/containers/image/v5 v5.8.0
github.com/gianarb/vagrant-go v0.0.0-20200902133321-62ba563fe383 // indirect
github.com/containers/image/v5 v5.10.5
github.com/gianarb/vagrant-go v0.0.0-20200902133321-62ba563fe383
github.com/go-git/go-git/v5 v5.2.0
github.com/joho/godotenv v1.3.0
github.com/pkg/errors v0.9.1
github.com/tinkerbell/tink v0.0.0-20210211152036-a7e947efc194 // indirect
github.com/tinkerbell/tink v0.0.0-20210315140655-1b178daeaeda
)
Loading

0 comments on commit c5dd65c

Please sign in to comment.