Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert one ipxe commit to unbreak intel 810 25 gigabit NICs #144

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

nshalman
Copy link
Member

@nshalman nshalman commented Feb 29, 2024

Follow up for #142 that includes a workaround for #143

This once again points us at a commit that I pushed to my fork. Reviewers should verify that the commit looks legit and is correctly a child of the commit it is replacing.

  • tested on an affected NIC

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (62314e0) to head (52f7e0f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files           5        5           
  Lines         367      367           
=======================================
  Hits          359      359           
  Misses          4        4           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nshalman nshalman changed the title Updates 20240229 Revert one ipxe commit to unbreak intel 810 25 gigabit NICs Mar 1, 2024
@nshalman nshalman marked this pull request as ready for review March 1, 2024 15:17
@jacobweinstock jacobweinstock added the ready-to-merge Mergify: Ready for Merging label Mar 1, 2024
@mergify mergify bot merged commit a76e908 into tinkerbell:main Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Mergify: Ready for Merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants