-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #30
Comments
It appears that on your machine |
That's funny, I've never realised MacOS symlinks these directories (it does the same with /etc and /var). That explains why the path-test fails. Perhaps it'd be an alternative to use stuff like |
Interesting. I was not aware of this either. What does scala> java.nio.file.Files.createTempDirectory("seed")
res11: java.nio.file.Path = /tmp/seed892158896148301201 Also, as per your suggestion on Gitter, we should not build within the repository such that after running the tests, |
Use `createTempDirectory` instead of `/tmp` for better portability. Closes #30.
Use `createTempDirectory` instead of `/tmp` for better portability. Closes #30.
- Use `createTempDirectory` instead of `/tmp` for better portability - PathUtil: Use `normalisePath` as `getCanonicalPath` resolves symbolic links The first change makes the test suite compatible with macOS. Closes #30.
I can't run all tests without getting errors. Seems like some path confusion. For instance, I get
but also a bunch of fails like this one:
I'm guessing this happens due to me running MacOS, but I'm not sure.
The text was updated successfully, but these errors were encountered: