Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: platform-specific modules do not generate -Xplugin: bloop definitions #16

Closed
megri opened this issue Jul 9, 2019 · 0 comments · Fixed by #29
Closed

Bug: platform-specific modules do not generate -Xplugin: bloop definitions #16

megri opened this issue Jul 9, 2019 · 0 comments · Fixed by #29
Labels
bug Something isn't working
Milestone
0.1.5

Comments

@megri
Copy link
Contributor

megri commented Jul 9, 2019 •
edited
Loading

Excerpt from #15 (comment)

We can add a test case derived from example-paradise to reproduce the faulty behaviour:

--- a/test/example-paradise/build.toml
+++ b/test/example-paradise/build.toml
@@ -9,6 +9,13 @@ scalaOptions   = ["-encoding", "UTF-8", "-unchecked", "-deprecation", "-Xfuture"
 root    = "macros"
 sources = ["macros"]
 targets = ["jvm", "js"]
+
+[module.macros.jvm]
+compilerDeps = [
+  ["org.scalamacros", "paradise", "2.1.1", "full"]
+]
+
+[module.macros.js]
 compilerDeps = [
   ["org.scalamacros", "paradise", "2.1.1", "full"]
 ]
tindzk added a commit that referenced this issue Jul 19, 2019
@tindzk
Add failing test case for issue #16
dbddfe5
tindzk added a commit that referenced this issue Jul 19, 2019
@tindzk
ScalaCompiler: Include plug-ins from platform modules
d5dfa68 
Closes #16.
@tindzk tindzk mentioned this issue Jul 19, 2019
Merged
@tindzk tindzk added the bug Something isn't working label Jul 19, 2019
@tindzk tindzk added this to the 0.1.5 milestone Jul 19, 2019
tindzk added a commit that referenced this issue Jul 22, 2019
@tindzk
Fix inheritance of compiler plug-ins
e519e47 
- ScalaCompiler: Include compiler plug-ins defined on platform
  module
- Coursier: Only return artefact path if requested version matches

Closes #16.
tindzk added a commit that referenced this issue Jul 22, 2019
@tindzk
Fix inheritance of compiler plug-ins
494a21a 
- ScalaCompiler: Include compiler plug-ins defined on platform
  module
- Coursier: Only return artefact path if requested version matches

Closes #16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.5
Development

Successfully merging a pull request may close this issue.

Fix inheritance of compiler plug-ins tindzk/seed
2 participants
@tindzk @megri