Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with mknotebooks and type: timeago #40

Closed
timvink opened this issue Jul 14, 2020 · 6 comments
Closed

Compatibility with mknotebooks and type: timeago #40

timvink opened this issue Jul 14, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@timvink
Copy link
Owner

timvink commented Jul 14, 2020

When inserting jupyter notebooks, the revisiondate remains blank when using type: timeago:

image

The info is there:

<div class="md-source-date"> 
<small> Last update: <span class="git-revision-date-localized-plugin git-revision-date-localized-plugin-timeago"><span class="timeago" datetime="2020-07-14T14:18:15+00:00" locale="en"></span></span><span class="git-revision-date-localized-plugin git-revision-date-localized-plugin-iso_date">2020-07-14</span> </small>
</div>

But it looks like the javascript injection does not work properly. Possibly #39 might fix this

@timvink timvink added the bug Something isn't working label Jul 14, 2020
@timvink
Copy link
Owner Author

timvink commented Oct 26, 2020

Released v.0.7.3 that addresses this.

@timvink timvink closed this as completed Oct 26, 2020
@timvink
Copy link
Owner Author

timvink commented Apr 13, 2021

This seems to be an issue again, with javascript injection not working properly.

@timvink timvink reopened this Apr 13, 2021
@timvink
Copy link
Owner Author

timvink commented Apr 22, 2021

so timeago is not loaded by javascript:

image

but the injection is there:

image

It works fine on pages that are not notebooks. I'm quite puzzled with this one.

@timvink
Copy link
Owner Author

timvink commented Apr 22, 2021

@timvink
Copy link
Owner Author

timvink commented Sep 3, 2021

Having a look at the linked issue, it seems the cause is outside of this plugin.

Once that issue has been addressed, it can be tested (manually) using a fixture included in this repo:

mkdocs serve -f tests/fixtures/with_mknotebooks/mkdocs.yml

@timvink
Copy link
Owner Author

timvink commented Sep 8, 2021

Works again after the latest update of mknotebook version 0.7.1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant