diff --git a/api_docs/kibana_react.json b/api_docs/kibana_react.json index ed9c5ef45c7f9..be534b1e0d15d 100644 --- a/api_docs/kibana_react.json +++ b/api_docs/kibana_react.json @@ -3719,48 +3719,15 @@ "label": "onChange", "description": [], "signature": [ - "(value: string, event: ", + "((value: string, event: ", "editor", - ".IModelContentChangedEvent) => void" + ".IModelContentChangedEvent) => void) | undefined" ], "source": { "path": "src/plugins/kibana_react/public/url_template_editor/url_template_editor.tsx", "lineNumber": 27 }, - "deprecated": false, - "returnComment": [], - "children": [ - { - "parentPluginId": "kibanaReact", - "id": "def-public.value", - "type": "string", - "tags": [], - "label": "value", - "description": [], - "source": { - "path": "src/plugins/kibana_react/public/code_editor/code_editor.tsx", - "lineNumber": 37 - }, - "deprecated": false - }, - { - "parentPluginId": "kibanaReact", - "id": "def-public.event", - "type": "Object", - "tags": [], - "label": "event", - "description": [], - "signature": [ - "editor", - ".IModelContentChangedEvent" - ], - "source": { - "path": "src/plugins/kibana_react/public/code_editor/code_editor.tsx", - "lineNumber": 37 - }, - "deprecated": false - } - ] + "deprecated": false }, { "parentPluginId": "kibanaReact", diff --git a/api_docs/kibana_react.mdx b/api_docs/kibana_react.mdx index 6b3efe2c90ea0..3a89efb7af28c 100644 --- a/api_docs/kibana_react.mdx +++ b/api_docs/kibana_react.mdx @@ -18,7 +18,7 @@ import kibanaReactObj from './kibana_react.json'; | Public API count | Any count | Items lacking comments | Missing exports | |-------------------|-----------|------------------------|-----------------| -| 257 | 5 | 228 | 4 | +| 258 | 5 | 228 | 4 | ## Client diff --git a/src/plugins/discover/public/application/components/json_code_editor/json_code_editor_common.tsx b/src/plugins/discover/public/application/components/json_code_editor/json_code_editor_common.tsx index e5ab8bf4d1a0d..cab4eae41afb8 100644 --- a/src/plugins/discover/public/application/components/json_code_editor/json_code_editor_common.tsx +++ b/src/plugins/discover/public/application/components/json_code_editor/json_code_editor_common.tsx @@ -56,7 +56,6 @@ export const JsonCodeEditorCommon = ({ languageId={XJsonLang.ID} width={width} value={jsonValue || ''} - onChange={() => {}} editorDidMount={onEditorDidMount} aria-label={codeEditorAriaLabel} options={{ diff --git a/src/plugins/discover/public/application/components/source_viewer/__snapshots__/source_viewer.test.tsx.snap b/src/plugins/discover/public/application/components/source_viewer/__snapshots__/source_viewer.test.tsx.snap index 68786871825ac..5f6dabc26659f 100644 --- a/src/plugins/discover/public/application/components/source_viewer/__snapshots__/source_viewer.test.tsx.snap +++ b/src/plugins/discover/public/application/components/source_viewer/__snapshots__/source_viewer.test.tsx.snap @@ -546,7 +546,6 @@ exports[`Source Viewer component renders json code editor 1`] = ` aria-label="Read only JSON view of an elasticsearch document" editorDidMount={[Function]} languageId="xjson" - onChange={[Function]} options={ Object { "automaticLayout": true, diff --git a/src/plugins/inspector/public/views/requests/components/details/req_code_viewer.tsx b/src/plugins/inspector/public/views/requests/components/details/req_code_viewer.tsx index 30aa32c6a2e89..8ef24e21ff578 100644 --- a/src/plugins/inspector/public/views/requests/components/details/req_code_viewer.tsx +++ b/src/plugins/inspector/public/views/requests/components/details/req_code_viewer.tsx @@ -54,7 +54,6 @@ export const RequestCodeViewer = ({ json }: RequestCodeViewerProps) => ( {}} options={{ readOnly: true, lineNumbers: 'off', diff --git a/src/plugins/kibana_react/public/code_editor/code_editor.tsx b/src/plugins/kibana_react/public/code_editor/code_editor.tsx index d5e7bbb71cac8..6b02d8d159617 100644 --- a/src/plugins/kibana_react/public/code_editor/code_editor.tsx +++ b/src/plugins/kibana_react/public/code_editor/code_editor.tsx @@ -34,7 +34,7 @@ export interface Props { value: string; /** Function invoked when text in editor is changed */ - onChange: (value: string, event: monaco.editor.IModelContentChangedEvent) => void; + onChange?: (value: string, event: monaco.editor.IModelContentChangedEvent) => void; /** * Options for the Monaco Code Editor diff --git a/src/plugins/vis_type_vega/public/vega_inspector/components/spec_viewer.tsx b/src/plugins/vis_type_vega/public/vega_inspector/components/spec_viewer.tsx index 178854550aff1..135c23b21d7d4 100644 --- a/src/plugins/vis_type_vega/public/vega_inspector/components/spec_viewer.tsx +++ b/src/plugins/vis_type_vega/public/vega_inspector/components/spec_viewer.tsx @@ -74,7 +74,6 @@ export const SpecViewer = ({ vegaAdapter, ...rest }: SpecViewerProps) => { {}} options={{ readOnly: true, lineNumbers: 'off', diff --git a/x-pack/plugins/data_enhanced/public/search/sessions_mgmt/components/actions/inspect_button.tsx b/x-pack/plugins/data_enhanced/public/search/sessions_mgmt/components/actions/inspect_button.tsx index 05382f3eb36ca..2272e4925ef8d 100644 --- a/x-pack/plugins/data_enhanced/public/search/sessions_mgmt/components/actions/inspect_button.tsx +++ b/x-pack/plugins/data_enhanced/public/search/sessions_mgmt/components/actions/inspect_button.tsx @@ -35,7 +35,6 @@ const InspectFlyout = ({ uiSettings, searchSession }: InspectFlyoutProps) => { {}} options={{ readOnly: true, lineNumbers: 'off', diff --git a/x-pack/plugins/file_upload/public/components/import_complete_view.tsx b/x-pack/plugins/file_upload/public/components/import_complete_view.tsx index a3bc2ed082b1a..70e1ac25a7ecc 100644 --- a/x-pack/plugins/file_upload/public/components/import_complete_view.tsx +++ b/x-pack/plugins/file_upload/public/components/import_complete_view.tsx @@ -75,7 +75,6 @@ export class ImportCompleteView extends Component { {}} options={{ readOnly: true, lineNumbers: 'off',