Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc tracking of unresolved issues/comments #87

Open
timotheecour opened this issue Apr 4, 2020 · 50 comments
Open

misc tracking of unresolved issues/comments #87

timotheecour opened this issue Apr 4, 2020 · 50 comments

Comments

@timotheecour
Copy link
Owner

timotheecour commented Apr 4, 2020

@timotheecour
Copy link
Owner Author

this is a bug. it'll only run for nim c since that's what's in cmd.

@timotheecour
Copy link
Owner Author

timotheecour commented Apr 12, 2020

1 branch per major.minor version
https://github.com/nim-lang/Nim/pull/13907#issuecomment-612545166

@timotheecour
Copy link
Owner Author

since debate nim-lang#13920 (comment)

@timotheecour
Copy link
Owner Author

nim-lang#7508 (comment)

@timotheecour
Copy link
Owner Author

this causes RT error Uncaught TypeError: a_2990031.$ is not a function

the bug is that it's inside a importcpp section so gets interpreted as such

@timotheecour
Copy link
Owner Author

@timotheecour timotheecour mentioned this issue Apr 21, 2020
1 task
@timotheecour
Copy link
Owner Author

nim-lang#14190 (comment)
warningAsError:warnUnreachableElse:on

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

nim-lang#14321 (comment) importc let tests

@timotheecour
Copy link
Owner Author

nim-lang#14331 (comment)

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

timotheecour commented May 28, 2020

nim-lang#14126 (comment)

causes significant regressions in stack usage due to RVO not being applied even in safe cases (no exceptions involved) - the proposed fix is too aggressive!

@timotheecour
Copy link
Owner Author

timotheecour commented Jun 13, 2020

nim-lang@d3b25a2#commitcomment-39878756

getCurrentExceptionMsg and getCurrentException() are available, they're just returning default values (instead of giving CT error or the actually exception string and exception).

@timotheecour timotheecour changed the title misc tracking of issues/comments misc tracking of unresolved issues/comments Oct 22, 2020
@timotheecour
Copy link
Owner Author

timotheecour commented Oct 24, 2020

https://github.com/nim-lang/Nim/pull/15701/files#r511508506
actionRetry

why did you remove this? this was there for a good reason, reducing spurious git clone failures which used to happen a lot before this was added

EDIT: maybe also related:
Error: unhandled exception: D:\a\1\s\tools\deps.nim(6, 12) status == 0 git clone -q https://github.com/nim-lang/nimble.git D:\a\1\s\dist\nimble [AssertionDefect]

https://dev.azure.com/nim-lang/Nim/_build/results?buildId=9633&view=logs&jobId=8771bebc-ff97-51ac-1845-cb5b61e3bccd&j=8771bebc-ff97-51ac-1845-cb5b61e3bccd&t=74a5fa6a-7085-521f-3e7a-45825f3ff79f

@timotheecour
Copy link
Owner Author

nim-lang#15705 (comment)

can you explain the added c.freeTemp(dest) in genBinaryStmtVar, genBinaryStmt, genAsgn, nkDerefExpr etc ?

Not anymore but I did review the entire VM codegen looking for register allocator leaks. Apparently my work wasn't good enough. ;-)

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

timotheecour commented Oct 30, 2020

D20201030T193806 narimiran@26816d5#r43738252

nim-lang#15792 (comment)

@timotheecour
Copy link
Owner Author

timotheecour commented Nov 2, 2020

nim-lang#8821 (comment)

@timotheecour
Copy link
Owner Author

timotheecour commented Nov 12, 2020

@timotheecour
Copy link
Owner Author

timotheecour commented Nov 12, 2020

Homebrew/brew#9120 (comment)
can you please re-open? I've edited OP and added brew config and brew doctor outputs

@timotheecour
Copy link
Owner Author

https://github.com/nim-lang/Nim/pull/15421/files#r522703485

TODO for future PR:
this will show weird looking errors:
input ['1', '2', ',', '1', '.'] [ValueError]
instead of:
input "12,1." [ValueError]

I sent out nim-lang#15951 ; when this is merged we can revisit this using add

@timotheecour
Copy link
Owner Author

nim-lang#15994 (comment)
contributing.rst: multiple error msgs via nim check

@timotheecour
Copy link
Owner Author

nim-lang#16087 (comment)

tests/collections/tsets.nim
instead of
tests/collections/thashsets.nim

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

timotheecour commented Nov 25, 2020

fix these:
Assignees TITLE: move tests to testament by xflywind · Pull Request #16101 · nim-lang/Nim

  • use include because some symbols are not exported
  • disable testing random module

@timotheecour
Copy link
Owner Author

nim-lang#16004 (comment)
std/sums => fusion/sums

@timotheecour
Copy link
Owner Author

timotheecour commented Nov 28, 2020

nim-lang#16163 (comment)

improve on:

doAssert fileExists(test), test & " test does not exist"

in testament

@timotheecour
Copy link
Owner Author

timotheecour commented Dec 10, 2020

yes. nim-lang#10841 should be revisited and nim-lang#10838 should be fixed in a way than amounts to adding {.noSideEffect.}

@timotheecour
Copy link
Owner Author

timotheecour commented Dec 18, 2020

@timotheecour
Copy link
Owner Author

where does this magic h > 4 comes from? shouldn't that at least be h > 2 ?

@timotheecour
Copy link
Owner Author

https://github.com/nim-lang/fusion/pull/56/files#r546161354

  • I think this should be ref object of JsRoot
  • we also need to fix similar errors in stdlib:
lib/js/dom.nim:1213:28:  TouchList* {.importc.} = ref object of RootObj
lib/js/dom.nim:1293:26:  TimeOut* {.importc.} = ref object of RootObj
lib/js/jsconsole.nim:16:17:type Console* = ref object of RootObj
lib/js/jsffi.nim:87:15:  JsObject* = ref object of JsRoot
lib/js/jsffi.nim:89:27:  JsAssoc*[K: JsKey, V] = ref object of JsRoot

PR's welcome!

@ringabout
Copy link
Collaborator

@timotheecour
Copy link
Owner Author

timotheecour commented Dec 27, 2020

the newer code is slower.

@timotheecour
Copy link
Owner Author

timotheecour commented Jan 13, 2021

@timotheecour
Copy link
Owner Author

For reference, I explained how to resolve this here: irclogs.nim-lang.org/13-01-2021.html#23:38:06

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

should this be arr: Float64Array or arr: var Float64Array ? I'm really not sure here since the type is ref, but really, Float64Array + friends act like seq, so var seems to make more sense here.

@timotheecour
Copy link
Owner Author

timotheecour commented Jan 26, 2021

please (in followup PR) move this to the existing tests/stdlib/tjsonmacro.nim inside testJson which automatically tests in c, js, vm

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

lineF(p, "$1 = nimCopy(null, $2, $3);$n",
               [a.rdLoc, b.res, genTypeInfo(p, y.typ)])

a few lines above also need to change to y.typ => x.typ?
(I don't know which one is correct)

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

timotheecour commented Feb 9, 2021

@timotheecour
Copy link
Owner Author

@timotheecour
Copy link
Owner Author

  • js foreign exception name

nim-lang#16998 (comment)

@SebTardif
Copy link

SebTardif commented Dec 1, 2023

Homebrew/brew#9120 (comment) can you please re-open? I've edited OP and added brew config and brew doctor outputs

I don't understands this ticket 87 and why 9120 is closed because I do see the error: "Error: Too many open files" every month on WSL when running "brew upgrade". Should I open a new issue for "Error: Too many open files"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants