Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse from string support #16

Closed
WyriHaximus opened this issue May 11, 2021 · 3 comments · Fixed by #17
Closed

Parse from string support #16

WyriHaximus opened this issue May 11, 2021 · 3 comments · Fixed by #17

Comments

@WyriHaximus
Copy link
Contributor

Looking at the source code this package currently only supports reading from a file. Would you be open to PR adding support for parsing directly from a string as well?

@timoschinkel
Copy link
Owner

My sincere apologies for the way too late response. There is no excuse.

What use-case do you have for reading from string?

The answer is yes; I would be open for a pull request.

@WyriHaximus
Copy link
Contributor Author

My sincere apologies for the way too late response. There is no excuse.

There is: You were busy with other things that were more important :).

What use-case do you have for reading from string?

Reading it from the GitHub API into memory before parsing it.

The answer is yes; I would be open for a pull request.

Here it is: #17

@timoschinkel timoschinkel linked a pull request Oct 19, 2021 that will close this issue
@timoschinkel
Copy link
Owner

Thank you for the pull request. This will be part of version 2.0. I hope to tag it later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants