Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ContinuationOptions to channels and synchronization primitives #483

Closed
timcassell opened this issue Oct 27, 2024 · 1 comment · Fixed by #485
Closed

Pass ContinuationOptions to channels and synchronization primitives #483

timcassell opened this issue Oct 27, 2024 · 1 comment · Fixed by #485
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@timcassell
Copy link
Owner

By default, channels and async synchronization primitives continue on the captured context. We can add overloads for users to configure that continuation behavior after the new options are merged in with #479.

@timcassell timcassell added the enhancement New feature or request label Oct 27, 2024
@timcassell timcassell added this to the v3.2.0 milestone Oct 27, 2024
@timcassell timcassell self-assigned this Oct 27, 2024
@timcassell timcassell linked a pull request Oct 28, 2024 that will close this issue
@timcassell
Copy link
Owner Author

timcassell commented Nov 1, 2024

I realized that the returned Promise could be completed before it is awaited, possibly making the continuation execute on a different context than the options. To fix this, we should instead pass a bool continueOnCapturedContext flag, and if users need it, they can use ConfigureAwait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant