Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO's after Timber 2.0 #147

Open
8 of 13 tasks
Levdbas opened this issue Nov 10, 2023 · 4 comments
Open
8 of 13 tasks

TODO's after Timber 2.0 #147

Levdbas opened this issue Nov 10, 2023 · 4 comments

Comments

@Levdbas
Copy link
Member

Levdbas commented Nov 10, 2023

Now Timber 2.0 is released I went though this repo and written down the things that could use some love. I could create a PR for 1,2, 4,5 and cleanup the issues if I can get access to this repo as well :)

  • update readme file, it still suggests the plugin.
  • update examples in readme. Some are very old.
  • maybe create a release or remove older releases.
  • is this file needed at all? https://github.com/timber/starter-theme/blob/2.x/views/page-plugin.twig
  • cleanup issues in repo
  • Adding a license?
  • Adding coding standard
  • Applying coding standard after merges
  • Fix PHPstan issues after merges
  • Overhauling the starter site class
  • PSR autoloading
  • CI: auto run PHPCS and PHPUNIT
  • Update minimal PHP version to 8.1 in PHP unit tests and phpstan/phpcs
@szepeviktor
Copy link
Contributor

Maybe choosing a coding standard?

@gchtr
Copy link
Member

gchtr commented Nov 23, 2023

@Levdbas I just invited you as a maintainer, so I’d be happy if you could work on that list of issues. I have nothing to add ad the moment.

You can find the relevant information here:

/**
* Third party plugins that hijack the theme will call wp_footer() to get the footer template.
* We use this to end our output buffer (started in header.php) and render into the view/page-plugin.twig template.
*
* If you're not using a plugin that requries this behavior (ones that do include Events Calendar Pro and
* WooCommerce) you can delete this file and header.php

@gchtr
Copy link
Member

gchtr commented Dec 7, 2023

I created a new release for 2.0: https://github.com/timber/starter-theme/releases/tag/2.0.0.

@Levdbas
Copy link
Member Author

Levdbas commented May 2, 2024

Hi @gchtr and @szepeviktor , A bunch of PR's have been created as a staring point for making the starter theme a bit more modern. I would like to have both your feedback if possible. Looking forward to the collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants