Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] RetryOperation does not free errors correctly, causing "forever" operations to leak memory #60

Open
atondelier opened this issue Oct 17, 2018 · 0 comments

Comments

@atondelier
Copy link

Hi,

It appears to me that the following splice call

      // retry forever, only keep last error
      this._errors.splice(this._errors.length - 1, this._errors.length);

is not doing what it says it does. It actually only removes the last element of _errors.

Since it has been there for 3 years and nobody complaining about it, I prefer checking with you before if:

  • this is an intended behavior
  • splicing with a length of the length of the Array was expected to splice at the head of the Array
  • or if I'm just completely wrong

Thanks for the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant