Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd_button should allow to set env variables #5910

Closed
fabriziopandini opened this issue Aug 1, 2022 · 4 comments
Closed

cmd_button should allow to set env variables #5910

fabriziopandini opened this issue Aug 1, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fabriziopandini
Copy link

Describe the Feature You Want

I would like to pass env variables to cmd_button, as I can do with local_resource

Current Behavior

cmd_button doesn't have an env argument

Why Do You Want This?

To pass env variables to the command defined in cmd_button without messing up os env variables

@nicks
Copy link
Member

nicks commented Aug 2, 2022

thanks for the request! shouldn't be too hard to add. the api exists on Cmd, just needs to get passed through the extension code that creates the Cmd:
https://github.com/tilt-dev/tilt-extensions/blob/master/uibutton/Tiltfile#L107
https://api.tilt.dev/core/cmd-v1alpha1.html

@g3kk0
Copy link

g3kk0 commented Aug 12, 2022

I would also like to very much see this feature.

@tylermichael
Copy link

I think this can be closed

@nicks nicks closed this as completed Oct 14, 2022
@fabriziopandini
Copy link
Author

Thanks team! Looking forward to use this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants