Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpmlint reports W: dangling-relative-symlink #25

Closed
martinkg opened this issue Jun 19, 2017 · 5 comments
Closed

rpmlint reports W: dangling-relative-symlink #25

martinkg opened this issue Jun 19, 2017 · 5 comments

Comments

@martinkg
Copy link

Rpmlint
-------
Checking: nuvola-app-amazon-cloud-player-5.4-3.fc27.noarch.rpm
          nuvola-app-amazon-cloud-player-5.4-3.fc27.src.rpm
nuvola-app-amazon-cloud-player.noarch: W: spelling-error %description -l en_US linux -> Linux
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/24x24/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/24.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/22x22/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/22.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/48x48/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/48.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/64x64/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/64.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/128x128/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/128.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/scalable/apps/nuvolaplayer3_amazon_cloud_player.svg ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/scalable.svg
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/16x16/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/16.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/256x256/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/256.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/32x32/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/32.png
nuvola-app-amazon-cloud-player.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppAmazonCloudPlayer.desktop nuvola
nuvola-app-amazon-cloud-player.src: W: spelling-error %description -l en_US linux -> Linux
nuvola-app-amazon-cloud-player.src:29: W: configure-without-libdir-spec
2 packages and 0 specfiles checked; 0 errors, 13 warnings.

This is the affected spec file: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-amazon-cloud-player.spec
@a-m-s
Copy link
Contributor

a-m-s commented Jun 19, 2017

@fenryxo This looks like it belongs elsewhere.

@martinkg
Copy link
Author

martinkg commented Jun 19, 2017

root@fc25 tmp]# ls -l /usr/share/icons/hicolor/256x256/apps/nuvolaplayer3_amazon_cloud_player.png
lrwxrwxrwx. 1 root root 68  7. Jun 11:48 /usr/share/icons/hicolor/256x256/apps/nuvolaplayer3_amazon_cloud_player.png -> ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/256.png

the link nuvolaplayer3_amazon_cloud_player.png points to file that are not existent.

[root@fc25 tmp]# rpm -ql nuvola-app-amazon-cloud-player |grep nuvolaplayer3
/usr/share/icons/hicolor/128x128/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/16x16/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/22x22/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/24x24/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/256x256/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/32x32/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/48x48/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/64x64/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/scalable/apps/nuvolaplayer3_amazon_cloud_player.svg

@voxik
Copy link

voxik commented Jun 21, 2017

I think this could be outfall of the nuvolaplayer -> nuvolaruntime rename.

@martinkg
Copy link
Author

@voxik

is it ok if i place the sed command in the %build section ?

%build
./configure --prefix=%{_prefix}
sed -i -e 's|nuvolaplayer3|nuvolaruntime|' Makefile
%make_build

@jiri-janousek
Copy link
Member

Issue moved to tiliado/nuvolasdk #3 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants