Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft client: make grpc message size limit configurable (#7816) #7824

Merged
merged 2 commits into from
May 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 13, 2020

cherry-pick #7816 to release-4.0


Signed-off-by: qupeng [email protected]

What problem does this PR solve?

Too large raft entry will cause raft client send failure.

Problem Summary:

What is changed and how it works?

Make grpc message size configurable in raft client.

Related changes

Check List

Tests

  • Integration test

Side effects

Release note

  • Make grpc message size limit configurable

@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot added component/server Component: Server type/cherry-pick Type: PR - Cherry pick labels May 13, 2020
@sre-bot sre-bot requested review from BusyJay and MyonKeminta May 13, 2020 07:57
@sre-bot sre-bot added this to the v4.0.0-rc.2 milestone May 13, 2020
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MyonKeminta
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

Your auto merge job has been accepted, waiting for:

  • 7817

@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

1 similar comment
@hicqu
Copy link
Contributor

hicqu commented May 13, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

@sre-bot merge failed.

@hicqu
Copy link
Contributor

hicqu commented May 13, 2020

/run-all-tests

1 similar comment
@hicqu
Copy link
Contributor

hicqu commented May 13, 2020

/run-all-tests

@hicqu hicqu merged commit 7884da7 into tikv:release-4.0 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server Component: Server status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants