Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.1] Unified Log Format #5083

Merged

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Jul 13, 2019

Signed-off-by: Breezewish [email protected]

What have you changed? (mandatory)

This PR cherry picks the unified log format formatter from 3.0 to 2.1.

Note: This PR does not introduce fields for log items.

What are the type of the changes? (mandatory)

  • New feature (change which adds functionality)

How has this PR been tested? (mandatory)

Manually and unit tests:

$ target/debug/tikv-server
[2019/07/13 11:44:14.561 +08:00] [INFO] [mod.rs:26] ["Welcome to TiKV. \nRelease Version:   2.1.14\nGit Commit Hash:   Unknown (env var does not exist when building)\nGit Commit Branch: Unknown (env var does not exist when building)\nUTC Build Time:    Unknown (env var does not exist when building)\nRust Version:      Unknown (env var does not exist when building)"]
[2019/07/13 11:44:14.563 +08:00] [INFO] [config.rs:152] ["no advertise-addr is specified, fall back to addr."]
[2019/07/13 11:44:14.564 +08:00] [ERROR] [tikv-server.rs:441] ["invalid configuration: StringError(\"please specify pd.endpoints.\")"]

@breezewish
Copy link
Member Author

/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@breezewish
Copy link
Member Author

breezewish commented Jul 13, 2019

@siddontang @BusyJay @AndreMouche PTAL, thanks!

@breezewish breezewish added priority/release-blocker This issue blocks a release. Please solve it ASAP. type/cherry-pick Type: PR - Cherry pick labels Jul 13, 2019
@breezewish
Copy link
Member Author

/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

1 similar comment
@youjiali1995
Copy link
Contributor

/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@BusyJay
Copy link
Member

BusyJay commented Jul 13, 2019

Why change the log format for 2.1? I think only bugfix is accepted.

@breezewish
Copy link
Member Author

@BusyJay Required by TEP team. I don't want to change it either.

@mahjonp
Copy link
Contributor

mahjonp commented Jul 15, 2019

/run-integration-ddl-test tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1

@siddontang
Copy link
Contributor

PTAL @BusyJay

@youjiali1995 youjiali1995 merged commit 35f0b38 into tikv:release-2.1 Jul 17, 2019
@breezewish breezewish deleted the release-2.1-unified-log-format branch July 17, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants