Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recycle log files #214

Closed
tabokie opened this issue Apr 18, 2022 · 3 comments
Closed

Recycle log files #214

tabokie opened this issue Apr 18, 2022 · 3 comments
Assignees
@LykxSassinator
Labels
enhancement New feature or request

Comments

@tabokie
Copy link
Member

tabokie commented Apr 18, 2022 •
edited
Loading

File allocation incurs big overhead, as #100 showed. We could reduce that overhead by reusing old log files. But directly recycling is not secure, because old log items could resurface under certain condition. One way to overcome this is to consider file id when calculating checksum for each log batch.
@tabokie tabokie added enhancement New feature or request help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 18, 2022
@LykxSassinator
Copy link
Contributor

I'll try to handle it.
To be continued.

@LykxSassinator LykxSassinator mentioned this issue Jun 15, 2022
Merged
@tabokie tabokie removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 12, 2022
@LykxSassinator
Copy link
Contributor

As the related issues, #224 and #249 , both are merged, can we close this issue now?

@tabokie
Copy link
Member Author

tabokie commented Aug 8, 2022

Will be released in v0.3.0 (TiKV v6.3).

@tabokie tabokie closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LykxSassinator LykxSassinator

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LykxSassinator @tabokie