Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedulers: skip uniform store to reduce schedule #5286

Merged
merged 5 commits into from
Aug 3, 2022
Merged

schedulers: skip uniform store to reduce schedule #5286

merged 5 commits into from
Aug 3, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 7, 2022 •
edited
Loading

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Ref #4949

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • HunDunDM

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 7, 2022
@ti-chi-bot ti-chi-bot requested review from nolouch and rleungx July 7, 2022 12:09
@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #5286 (ffa537f) into master (8307fe8) will increase coverage by 0.02%.
The diff coverage is 84.21%.

❗ Current head ffa537f differs from pull request most recent head 70315e8. Consider uploading reports for the commit 70315e8 to get more accurate results

@@            Coverage Diff             @@
##           master    #5286      +/-   ##
==========================================
+ Coverage   75.59%   75.61%   +0.02%     
==========================================
  Files         312      312              
  Lines       31054    31064      +10     
==========================================
+ Hits        23476    23490      +14     
- Misses       5563     5564       +1     
+ Partials     2015     2010       -5
Flag Coverage Δ
unittests 75.61% <84.21%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region_config.go 89.04% <50.00%> (-1.15%) ⬇️
server/schedulers/hot_region.go 85.02% <100.00%> (+0.07%) ⬆️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/storage/kv/etcd_kv.go 69.56% <0.00%> (-10.15%) ⬇️
server/election/leadership.go 73.19% <0.00%> (-4.13%) ⬇️
server/member/member.go 62.10% <0.00%> (-3.69%) ⬇️
server/schedule/operator/step.go 74.74% <0.00%> (-1.02%) ⬇️
server/tso/allocator_manager.go 62.18% <0.00%> (-0.67%) ⬇️
server/tso/tso.go 70.05% <0.00%> (-0.57%) ⬇️
server/config/persist_options.go 93.37% <0.00%> (+0.34%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8307fe8...70315e8. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2022
@lhy1024 lhy1024 marked this pull request as ready for review August 3, 2022 03:59
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@lhy1024
add uniform filter
8e652c5 
Signed-off-by: lhy1024 <[email protected]>
CabinfeverB
CabinfeverB approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

server/schedulers/hot_region.go
hotSchedulerResultCounter.WithLabelValues("skip-uniform-store", strconv.FormatUint(bs.cur.dstStore.GetID(), 10)).Inc()
tryUpdateBestSolution := func() {
if label, ok := bs.filterUniformStore(); ok {
schedulerCounter.WithLabelValues(bs.sche.GetName(), fmt.Sprintf("%s-skip-%s-uniform-store", bs.rwTy.String(), label)).Inc()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not still using hotSchedulerResultCounter

Copy link
Contributor Author

@lhy1024 lhy1024 Aug 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous monitor location is wrong

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8e652c5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 3, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@lhy1024
remove some empty line
70315e8 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 70315e8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@ti-chi-bot ti-chi-bot merged commit 99e38eb into tikv:master Aug 3, 2022
@lhy1024 lhy1024 deleted the uniform branch August 3, 2022 09:21
@lhy1024 lhy1024 mentioned this pull request Sep 14, 2022
Closed
25 tasks
@lhy1024 lhy1024 mentioned this pull request Sep 22, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhy1024 @ti-chi-bot @HunDunDM @CabinfeverB