Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: enlarge the search space so that the hot-scheduler can still schedule under dimensional conflicts #4912

Merged
merged 11 commits into from
Jun 7, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented May 9, 2022

What problem does this PR solve?

Issue Number: Ref #4949

What is changed and how does it work?

  1. enlarge the search space so that the hot-scheduler can still schedule under dimensional conflicts
  2. Introduce stddev to reduce unnecessary scheduling

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

master

image

master with close strcit-pick

image

pr

image

Release note

enlarge the search space so that the hot-scheduler can still schedule under dimensional conflicts

@lhy1024 lhy1024 added component/scheduler Scheduler logic. component/statistics Statistics for scheduling. labels May 9, 2022
@lhy1024 lhy1024 requested review from nolouch and HunDunDM May 9, 2022 08:44
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 9, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2022
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2022
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2022
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2022
@nolouch
Copy link
Contributor

nolouch commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 30d3196

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #4912 (1db24bf) into master (1f3c305) will increase coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head 1db24bf differs from pull request most recent head 1155fd6. Consider uploading reports for the commit 1155fd6 to get more accurate results

@@            Coverage Diff             @@
##           master    #4912      +/-   ##
==========================================
+ Coverage   75.40%   75.62%   +0.21%     
==========================================
  Files         308      308              
  Lines       30484    30498      +14     
==========================================
+ Hits        22987    23064      +77     
+ Misses       5491     5449      -42     
+ Partials     2006     1985      -21     
Flag Coverage Δ
unittests 75.62% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 83.52% <100.00%> (+0.19%) ⬆️
server/statistics/store_hot_peers_infos.go 100.00% <100.00%> (ø)
server/statistics/store_load.go 95.79% <100.00%> (+0.03%) ⬆️
pkg/cache/cache.go 53.57% <0.00%> (-10.72%) ⬇️
server/schedule/hbstream/heartbeat_streams.go 72.72% <0.00%> (-9.10%) ⬇️
server/schedulers/evict_leader.go 78.82% <0.00%> (-0.91%) ⬇️
server/config/persist_options.go 93.09% <0.00%> (-0.73%) ⬇️
server/schedule/checker/rule_checker.go 79.18% <0.00%> (-0.72%) ⬇️
server/schedule/checker/checker_controller.go 77.50% <0.00%> (-0.55%) ⬇️
server/server.go 72.53% <0.00%> (-0.28%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3c305...1155fd6. Read the comment docs.

@nolouch
Copy link
Contributor

nolouch commented Jun 7, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1db24bf

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed do-not-merge/needs-linked-issue labels Jun 7, 2022
@ti-chi-bot ti-chi-bot merged commit 726d345 into tikv:master Jun 7, 2022
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
…ll schedule under dimensional conflicts (tikv#4912)

ref tikv#4949

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
lhy1024 added a commit to lhy1024/pd that referenced this pull request Aug 3, 2022
… can still schedule under dimensional conflicts (tikv#4912)"

    This reverts commit  726d345.

Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 deleted the stddev branch August 3, 2022 07:18
ti-chi-bot pushed a commit that referenced this pull request Aug 4, 2022
ti-chi-bot pushed a commit that referenced this pull request Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. component/statistics Statistics for scheduling. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants