Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: refine log in some packages (#2885) #2913

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2885 to release-4.0


What problem does this PR solve?

Part of #2704.

What is changed and how it works?

This PR refines logs in some packages according to RFC.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

@ti-srebot ti-srebot added component/log Log. require-LGT1 Indicates that the PR requires an LGTM. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Sep 7, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 7, 2020
@rleungx rleungx force-pushed the release-4.0-e352969cc4c4 branch from ec2cd74 to ace48e7 Compare September 7, 2020 09:54
@rleungx rleungx force-pushed the release-4.0-e352969cc4c4 branch from ace48e7 to 4e80605 Compare September 7, 2020 09:56
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2913 into release-4.0 will decrease coverage by 0.00%.
The diff coverage is 36.92%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2913      +/-   ##
===============================================
- Coverage        77.34%   77.34%   -0.01%     
===============================================
  Files              210      209       -1     
  Lines            22854    22847       -7     
===============================================
- Hits             17676    17670       -6     
+ Misses            3839     3834       -5     
- Partials          1339     1343       +4     
Impacted Files Coverage Δ
server/api/member.go 60.00% <0.00%> (ø)
server/core/region_storage.go 81.81% <0.00%> (ø)
server/core/region_tree.go 93.27% <0.00%> (ø)
server/grpc_service.go 60.90% <0.00%> (+0.75%) ⬆️
server/member/leader.go 71.53% <0.00%> (-0.77%) ⬇️
server/region_syncer/server.go 80.55% <0.00%> (ø)
server/schedule/region_scatterer.go 86.14% <0.00%> (-0.53%) ⬇️
server/kv/levedb_kv.go 78.37% <25.00%> (-4.48%) ⬇️
server/schedule/operator_controller.go 81.41% <28.57%> (ø)
server/cluster/cluster.go 80.89% <33.33%> (-0.02%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b510897...4e80605. Read the comment docs.

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 7, 2020
@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants