-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: fix the issue that some scheduler persist config without solving error (#2817) #2818
scheduler: fix the issue that some scheduler persist config without solving error (#2817) #2818
Conversation
Signed-off-by: ti-srebot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2818 +/- ##
===============================================
+ Coverage 77.56% 77.87% +0.31%
===============================================
Files 208 208
Lines 22768 22765 -3
===============================================
+ Hits 17660 17729 +69
+ Misses 3792 3708 -84
- Partials 1316 1328 +12
Continue to review full report at Codecov.
|
/merge |
Your auto merge job has been accepted, waiting for:
|
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
cherry-pick #2817 to release-4.0
Signed-off-by: lhy1024 [email protected]
What problem does this PR solve?
fix the issue that some scheduler persist config without solving error
What is changed and how it works?
return with error
Check List
Tests
Release note