Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: unify error handling by removing pkg/errors (#2644) #2806

Merged
merged 1 commit into from
Sep 7, 2020
Merged

*: unify error handling by removing pkg/errors (#2644) #2806

merged 1 commit into from
Sep 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2644 to release-4.0

What problem does this PR solve?

Close #2643.

What is changed and how it works?

This PR replaces pkg/errors with pingcap/errors.

Check List

Tests

  • Unit test

Release note

@ti-srebot ti-srebot mentioned this pull request Aug 20, 2020
Merged
@ti-srebot ti-srebot added component/misc Some other things. require-LGT1 Indicates that the PR requires an LGTM. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick labels Aug 20, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Aug 20, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Aug 24, 2020

we need to fix conflict

@rleungx rleungx force-pushed the release-4.0-bcfa77a7a593 branch 2 times, most recently from c06b114 to 45bb0f2 Compare September 2, 2020 11:20
@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #2806 into release-4.0 will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2806      +/-   ##
===============================================
- Coverage        77.51%   77.43%   -0.08%     
===============================================
  Files              210      210              
  Lines            22784    22784              
===============================================
- Hits             17660    17643      -17     
- Misses            3801     3814      +13     
- Partials          1323     1327       +4
Impacted Files Coverage Δ
client/client.go 72.43% <ø> (+0.48%) ⬆️
pkg/apiutil/apiutil.go 67.34% <ø> (ø)
pkg/codec/codec.go 78.57% <ø> (ø)
pkg/etcdutil/etcdutil.go 88.40% <ø> (-2.90%) ⬇️
pkg/grpcutil/grpcutil.go 71.42% <ø> (ø)
pkg/logutil/log.go 85.27% <ø> (ø)
pkg/typeutil/convension.go 100.00% <ø> (ø)
pkg/typeutil/duration.go 78.94% <ø> (ø)
pkg/typeutil/size.go 41.17% <ø> (ø)
pkg/typeutil/string_slice.go 81.81% <ø> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e7167...eadd6d9. Read the comment docs.

JmPotato
JmPotato approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 3, 2020
@rleungx
Copy link
Member

rleungx commented Sep 3, 2020

/run-all-tests

@rleungx rleungx force-pushed the release-4.0-bcfa77a7a593 branch from 45bb0f2 to fe389a7 Compare September 7, 2020 03:22
@rleungx rleungx force-pushed the release-4.0-bcfa77a7a593 branch from fe389a7 to eadd6d9 Compare September 7, 2020 03:46
@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/run-all-tests

@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit d22b12a into tikv:release-4.0 Sep 7, 2020
This was referenced Sep 10, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato JmPotato approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

@nolouch nolouch Awaiting requested review from nolouch

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees

@rleungx rleungx

Labels
component/misc Some other things. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lhy1024 @rleungx @JmPotato