server/core: check region term before updating cache (#2667) #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
ti-srebot
added
contribution
|
@JmPotato,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2672 +/- ##
===============================================
- Coverage 77.17% 77.16% -0.01%
===============================================
Files 205 205
Lines 22232 22237 +5
===============================================
+ Hits 17157 17159 +2
- Misses 3768 3771 +3
Partials 1307 1307
Continue to review full report at Codecov.
|
ti-srebot
added
status/LGT1
nolouch
approved these changes
Jul 23, 2020
ti-srebot
added
status/LGT2
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2667 to release-4.0
Signed-off-by: howardlau1999 [email protected]
What problem does this PR solve?
Close #2657
What is changed and how it works?
Collect the
termfield in the heartbeat message intoRegionInfoand check if the term is greater than the one in cache to avoid invalid cache updates.Check List
Tests
Code changes
PreCheckPutRegionchangedtermin structRegionInfoRelease note
Avoid invalid cache updates after the leader of a region has changed.