Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric field is useless in grafana json #8381

Closed
okJiang opened this issue Jul 9, 2024 · 0 comments · Fixed by #8382
Closed

metric field is useless in grafana json #8381

okJiang opened this issue Jul 9, 2024 · 0 comments · Fixed by #8382
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@okJiang
Copy link
Member

okJiang commented Jul 9, 2024

Enhancement Task

  • metric field is useless and there is confusion with the expression.

for example

pd/metrics/grafana/pd.json

Lines 856 to 869 in 90273dd

"targets": [
{
"exemplar": true,
"expr": "service_member_role{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\"}",
"format": "table",
"instant": true,
"interval": "",
"intervalFactor": 2,
"legendFormat": "",
"metric": "pd_server_tso",
"refId": "A",
"step": 40
}
],

@okJiang okJiang added the type/enhancement The issue or PR belongs to an enhancement. label Jul 9, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 0d97641 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant