Unsafe data race caused by the global TSO request pool #8076
Labels
affects-8.1
This bug affects the 8.1.x(LTS) versions.
severity/critical
type/bug
The issue is confirmed as a bug.
Comments
JmPotato
added
affects-8.1
ti-chi-bot bot
added a commit
that referenced
this issue
Apr 17, 2024
…data race (#8077) close #8055, ref #8076 Use the TSO request pool at the `tsoClient` level to avoid data race. Signed-off-by: JmPotato <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot
pushed a commit
that referenced
this issue
Apr 30, 2024
…data race (#8077) (#8141) close #8055, ref #8076 Use the TSO request pool at the `tsoClient` level to avoid data race. Signed-off-by: JmPotato <[email protected]> Co-authored-by: JmPotato <[email protected]>
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
If
(*client).dispatchTSORequestWithRetrydirectly callstryDone()due to the error of context canceled, the caller might get the TSO result and put the request back into the pool. At this time, the oldtsoClientmay have data races with the newtsoClientwhen cleaning up residual TSO requests.This is also the root cause of #8055.
The text was updated successfully, but these errors were encountered: