Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region fit rule should run once. #5537

Closed
Tracked by #5473
bufferflies opened this issue Sep 21, 2022 · 0 comments · Fixed by #5640
Closed
Tracked by #5473

region fit rule should run once. #5537

bufferflies opened this issue Sep 21, 2022 · 0 comments · Fixed by #5640
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@bufferflies
Copy link
Contributor

bufferflies commented Sep 21, 2022

In past, the SelectOneRegion function has fit the region rule , then the NewPlacementSafeguard also fit it.

some relate code:

func (f *regionReplicatedFilter) Select(region *core.RegionInfo) *plan.Status {
if f.cluster.GetOpts().IsPlacementRulesEnabled() {
if !isRegionPlacementRuleSatisfied(f.cluster, region) {
return statusRegionNotMatchRule
}
return statusOK
}
if !isRegionReplicasSatisfied(f.cluster, region) {
return statusRegionNotReplicated
}
return statusOK
}

@ti-chi-bot ti-chi-bot added the needs-type Indicates an issue requires a type label. label Sep 21, 2022
@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Sep 30, 2022
@ti-chi-bot ti-chi-bot removed the needs-type Indicates an issue requires a type label. label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants