-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: make region statistic loss some precision #3728
Conversation
Signed-off-by: nolouch <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3728 +/- ##
==========================================
+ Coverage 74.81% 75.01% +0.20%
==========================================
Files 244 244
Lines 24423 24437 +14
==========================================
+ Hits 18271 18332 +61
+ Misses 4521 4487 -34
+ Partials 1631 1618 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
9f4f642
to
aac86d8
Compare
Signed-off-by: nolouch <[email protected]>
aac86d8
to
ddf7f42
Compare
Signed-off-by: nolouch <[email protected]>
d50f787
to
231d297
Compare
Signed-off-by: nolouch <[email protected]>
32e465c
to
f4c3d20
Compare
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
08b196c
to
57190b3
Compare
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
pkg/errs/errno.go
Outdated
@@ -271,6 +271,11 @@ var ( | |||
ErrSemverNewVersion = errors.Normalize("new version error", errors.RFCCodeText("PD:semver:ErrSemverNewVersion")) | |||
) | |||
|
|||
// config | |||
var ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the error is PD:filepath:ErrFilePathAbs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. PTAL
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: e1293db
|
@nolouch: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
* add the loss precision Signed-off-by: nolouch <[email protected]> * fix comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comments Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * fix Signed-off-by: nolouch <[email protected]> * clean Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
* add the loss precision Signed-off-by: nolouch <[email protected]> * fix comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comments Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * fix Signed-off-by: nolouch <[email protected]> * clean Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> * address comment Signed-off-by: nolouch <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
Signed-off-by: nolouch [email protected]
What problem does this PR solve?
In the current situation, a change in traffic will trigger the update of
save cache
in the region heartbeat, which will cause the heartbeat to become more stressful. In fact, this part of the statistical data can work normally as long as it is within a certain accuracy.What is changed and how it works?
Check List
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Release note