Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent add TiFlash Nodes without placement rules #2237

Closed
disksing opened this issue Mar 13, 2020 · 0 comments · Fixed by #2242
Closed

Prevent add TiFlash Nodes without placement rules #2237

disksing opened this issue Mar 13, 2020 · 0 comments · Fixed by #2242
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@disksing
Copy link
Contributor

Feature Request

Describe your feature request related problem:

TiFlash nodes cannot become follower or learner. We use placement rules to prevent moving followers or leaders to TiFlash nodes. If user forget to set up placement rules before adding TiFlash nodes, it will cause TiFlash nodes crash.

Describe the feature you'd like:

  • When placement rules not enabled, don't allow add tiflash node.
  • When the cluster has tiFlash nodes, don't allow disable placement rules.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant