Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider enable dialClient keepalive again #1718

Open
disksing opened this issue Aug 30, 2019 · 2 comments
Open

consider enable dialClient keepalive again #1718

disksing opened this issue Aug 30, 2019 · 2 comments
Assignees

Comments

@disksing
Copy link
Contributor

Previously, we have disabled keepalive in #969 due to #971. I think if we can reuse clients, there won't be too many connections, so we should enable it again.

@disksing
Copy link
Contributor Author

@siddontang

@siddontang
Copy link
Contributor

I think we misuse the client:

resp, err := dialClient.Get(fmt.Sprintf("%s%s", cURL, healthURL))
if resp != nil {
		resp.Body.Close()
}

we should read all body before close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants