Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature alloc_trait can not compile with the current Rust version #38

Open
MrCroxx opened this issue Aug 30, 2022 · 3 comments
Open

feature alloc_trait can not compile with the current Rust version #38

MrCroxx opened this issue Aug 30, 2022 · 3 comments

Comments

@MrCroxx
Copy link
Member

MrCroxx commented Aug 30, 2022

Feature alloc_trait cannot compile because the interface core::alloc::Excess has been removed and core::alloc::Alloc is replaced by core::alloc::Allocator and its interfaces are changed.

I fixed it in my own repo by imitating std::alloc::System (PR), but I'm not sure if it's the best way.

Is there any advises for it?

@BusyJay
Copy link
Member

BusyJay commented Aug 30, 2022

Feel free to contribute it to jemallocator. Though we need to consider whether the implementation can be optimized for jemalloc specifically.

@BusyJay
Copy link
Member

BusyJay commented Feb 17, 2023

Hi, @MrCroxx. Do you have time to send a PR?

@MrCroxx
Copy link
Member Author

MrCroxx commented Feb 18, 2023

@BusyJay There was a PR and I've used it well for some time in my own project. But I'm not sure how the naive implementation works in more general cases. Feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants