Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LockNoWait does not take effect #434

Closed
sticnarf opened this issue Mar 2, 2022 · 0 comments · Fixed by #435
Closed

LockNoWait does not take effect #434

sticnarf opened this issue Mar 2, 2022 · 0 comments · Fixed by #435
Assignees
@sticnarf
Labels
bug Something isn't working

Comments

@sticnarf
Copy link
Collaborator

sticnarf commented Mar 2, 2022

From the proto, negative wait_timeout means no wait:

https://github.com/pingcap/kvproto/blob/9bb22e5a97fc47b9d27f4e053b44507217735f4d/proto/kvrpcpb.proto#L144

But now, LockNoWait is set to zero, which means the default timeout on TiKV

client-go/kv/kv.go

Line 45 in b5eb031

LockNoWait = int64(0)

This causes locking with LockNoWait to wait for the default timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sticnarf sticnarf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect LockNoWait value sticnarf/client-go
1 participant
@sticnarf