You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also I would suggest to improve the formatting of the message:
pnpm-sync: Copied 107 files in 95ms from C:\Git\rushstack\libraries\terminal
It seems pnpmSyncCopy() is printing this message directly to the console. We should improve the API to provide a messaging callback that allows the output to be redirected and (ideally) optionally reformatted. Something like this:
pnpmSyncCopy({
pnpmSyncJsonPath,messageCallback: ({ message,messageKind: 'error'|'warning'|'info'|'verbose'|'timing', messageId, details })=>{if(messageKind==='verbose'&&!debug){return;}switch(messageId){case 'sync-finished':
// customized logging; the structure of details can depend on messageIdterminal.writeLine(colors.green('pnpm-sync')+` copied ${details.fileCount} files in ${details.totalMs} ms from ${details.sourcePath}`);break;
default:
// simple preformatted loggingif(messageKind==='error'|messageKind==='warning'){console.error(message);}else{console.log(message);}break;}}})
This would ensure that Rush (and in the future PNPM) has full ownership of its CLI UX.
The text was updated successfully, but these errors were encountered:
From https://github.com/microsoft/rushstack/pull/4530/files#r1504932679:
The text was updated successfully, but these errors were encountered: