Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sonor cloud issue 8 #1455

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Fix/sonor cloud issue 8 #1455

wants to merge 13 commits into from

Conversation

TakanoTaiga
Copy link
Member

@TakanoTaiga TakanoTaiga commented Nov 19, 2024 •
edited
Loading

Description

Abstract

This PR includes modifications based on the results of static analysis performed by SonarCloud. Please refer to the SonarCloud reference for details on the issue fixes.

Background

N/A

Details

N/A

References

Replace the redundant type with "auto".

implicit conversion loses floating-point precision: 'double' to 'const float'

Remove this redundant cast.

unused exception parameter 'e'

Replace this declaration by a structured binding declaration.

This function should be declared "const".

Remove the commented out code.

Use "override" or "final" instead of "virtual".

Annotate this function with "override" or "final".

Destructive Changes

N/A

Known Limitations

N/A

@TakanoTaiga TakanoTaiga self-assigned this Nov 19, 2024
@TakanoTaiga TakanoTaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Nov 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited by hakuturu583
Loading

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@TakanoTaiga TakanoTaiga marked this pull request as ready for review November 26, 2024 14:03
hakuturu583
hakuturu583 requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Start regression test.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
43.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakuturu583 hakuturu583 hakuturu583 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@TakanoTaiga TakanoTaiga

Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TakanoTaiga @hakuturu583